<html>
<head><meta charset="utf-8"><title>weekly meeting 2019-05-09 #54818 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html">weekly meeting 2019-05-09 #54818</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="165254845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165254845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165254845">(May 09 2019 at 14:01)</a>:</h4>
<p>Hello <span class="user-group-mention" data-user-group-id="897">@T-compiler/meeting</span>! Triage meeting starting now. You can find the <a href="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-05-09.20.2354818" title="#narrow/stream/131828-t-compiler/topic/pre-meeting.20triage.202019-05-09.20.2354818">pre-triage topic</a> here -- mostly I assigned priorities to nominated things.</p>



<a name="165254942"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165254942" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165254942">(May 09 2019 at 14:02)</a>:</h4>
<p>Let me start by highlighting some issues for which we could use volunteers <span aria-label="hand" class="emoji emoji-270b" role="img" title="hand">:hand:</span> , or where I would like some feedback</p>



<a name="165255002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255002">(May 09 2019 at 14:03)</a>:</h4>
<ul>
<li>Exponential compile-time and type_length_limit blowup when nesting closure wrappers <a href="https://github.com/rust-lang/rust/issues/54540" target="_blank" title="https://github.com/rust-lang/rust/issues/54540">#54540</a> </li>
</ul>
<p>I think that <span class="user-mention" data-user-id="119009">@eddyb</span> had a prety specific proposal on this that seemed actionable. However, I can't find those comments right now. =) It's currently p-medium, but it's blocking a p-high regression that seems similar.</p>



<a name="165255081"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255081" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255081">(May 09 2019 at 14:03)</a>:</h4>
<ul>
<li>compiler panic "randomly" with incremental build <a href="https://github.com/rust-lang/rust/issues/60629" target="_blank" title="https://github.com/rust-lang/rust/issues/60629">#60629</a> </li>
</ul>
<p>This is an incremental panic that a few people have highlighted. It looks like it's "close" to have a clear reproduction, but not quite. It'd be awesome if somebody could try and make a clear reproduction (i.e., compile this, apply this patch, compile again).</p>



<a name="165255222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255222">(May 09 2019 at 14:05)</a>:</h4>
<ul>
<li>Compiler crash when dealing with Any and Ref <a href="https://github.com/rust-lang/rust/issues/60622" target="_blank" title="https://github.com/rust-lang/rust/issues/60622">#60622</a> </li>
</ul>
<p>A regression from 1.30 that <a href="https://github.com/rust-lang/rust/issues/60622#issuecomment-490317852" target="_blank" title="https://github.com/rust-lang/rust/issues/60622#issuecomment-490317852">@**centril** has helpfully reduced</a>. Looks like it is somewhere around HIR lowering or something? A bit hard to tell.</p>



<a name="165255267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255267">(May 09 2019 at 14:05)</a>:</h4>
<ul>
<li>Regression: Typemap type mismatch in 1.34.0+ <a href="https://github.com/rust-lang/rust/issues/60375" target="_blank" title="https://github.com/rust-lang/rust/issues/60375">#60375</a> </li>
</ul>
<p>This causes crashes on windows and may be windows specific. Something in the runtime behavior of <code>TypeMap</code> seems to have changed. The work here would be to try and narrow down the problem.</p>



<a name="165255345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255345">(May 09 2019 at 14:06)</a>:</h4>
<p>OK, that's all I have in my notes, but there are also a large number of <a href="https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AP-high+label%3AT-compiler+no%3Aassignee" target="_blank" title="https://github.com/rust-lang/rust/issues?q=is%3Aopen+is%3Aissue+label%3AP-high+label%3AT-compiler+no%3Aassignee">unassigned P-high issues</a>.</p>



<a name="165255377"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255377" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255377">(May 09 2019 at 14:06)</a>:</h4>
<p>Before we look at that, I wanted to start by looking at a beta/stable nomination</p>



<a name="165255407"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255407" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255407">(May 09 2019 at 14:07)</a>:</h4>
<blockquote>
<p>save-analysis: Fix ICE when processing associated constant <a href="https://github.com/rust-lang/rust/issues/60649" target="_blank" title="https://github.com/rust-lang/rust/issues/60649">#60649</a></p>
</blockquote>



<a name="165255443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255443">(May 09 2019 at 14:07)</a>:</h4>
<p>This is a PR by <span class="user-mention" data-user-id="153740">@Igor Matuszewski</span> that, I believe, seems to fix some important RLS regressions. I've not created a poll yet, I see there were some comments by <span class="user-mention" data-user-id="124288">@oli</span>.</p>



<a name="165255535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255535">(May 09 2019 at 14:08)</a>:</h4>
<p>Actually, based on comments in the PR, I guess it's mostly 'beta nominated', since a point release is unlikely.</p>



<a name="165255555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255555">(May 09 2019 at 14:08)</a>:</h4>
<p>/poll Should we backport <a href="https://github.com/rust-lang/rust/issues/60649" target="_blank" title="https://github.com/rust-lang/rust/issues/60649">#60649</a>?</p>



<a name="165255580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Wesley Wiser <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255580">(May 09 2019 at 14:09)</a>:</h4>
<p>(Do we have any mobile users for whom the poll will not show)</p>



<a name="165255582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255582">(May 09 2019 at 14:09)</a>:</h4>
<p>I don't grok save_analysis and don't have time to dig in deeper as to why my ideas don't fit. The change fixes the panic and it's semi-clear to me why it does, so my comments are resolved</p>



<a name="165255598"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255598" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255598">(May 09 2019 at 14:09)</a>:</h4>
<p>feel free to use either emoji <em>or</em> poll</p>



<a name="165255612"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255612" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255612">(May 09 2019 at 14:09)</a>:</h4>
<p>or whatever :)</p>



<a name="165255618"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255618" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255618">(May 09 2019 at 14:09)</a>:</h4>
<p>it's just to get a rough sense anyway</p>



<a name="165255702"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255702" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255702">(May 09 2019 at 14:10)</a>:</h4>
<p>OK, i'm going to mark that as beta-accepted</p>



<a name="165255814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255814">(May 09 2019 at 14:11)</a>:</h4>
<p>OK, so, let's see -- we have a bunch of P-high issues, and we have I-nominated issues.</p>



<a name="165255889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255889">(May 09 2019 at 14:12)</a>:</h4>
<p>Let's do I-nominated</p>



<a name="165255920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255920">(May 09 2019 at 14:12)</a>:</h4>
<blockquote>
<p>Hide type errors likely caused by incorrect struct literal <a href="https://github.com/rust-lang/rust/issues/60118" target="_blank" title="https://github.com/rust-lang/rust/issues/60118">#60118</a> </p>
</blockquote>
<p>I think we resolved this, right? At least, we would want to do more design here? (cc <span class="user-mention" data-user-id="119031">@Esteban Küber</span>)</p>



<a name="165255933"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255933" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255933">(May 09 2019 at 14:13)</a>:</h4>
<blockquote>
<p>add support for unchecked math <a href="https://github.com/rust-lang/rust/issues/59148" target="_blank" title="https://github.com/rust-lang/rust/issues/59148">#59148</a></p>
</blockquote>



<a name="165255973"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255973" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255973">(May 09 2019 at 14:13)</a>:</h4>
<p>the proposal is to add various intrinsics for arithmetic where it is UB to overflow, to aid in optimization</p>



<a name="165255979"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165255979" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165255979">(May 09 2019 at 14:13)</a>:</h4>
<p>lang team says "experiment away but do not expose publicly"</p>



<a name="165256033"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256033" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256033">(May 09 2019 at 14:14)</a>:</h4>
<p>I can close <a href="https://github.com/rust-lang/rust/issues/60118" target="_blank" title="https://github.com/rust-lang/rust/issues/60118">#60118</a></p>



<a name="165256056"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256056" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256056">(May 09 2019 at 14:14)</a>:</h4>
<p>I'm inclined to say "compiler team says this is fine" -- it's not like it's a real maintenance burden for us?</p>



<a name="165256066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256066">(May 09 2019 at 14:14)</a>:</h4>
<p>(it's basically exposing some LLVM intrinsics)</p>



<a name="165256096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256096">(May 09 2019 at 14:14)</a>:</h4>
<p>I'm going to go with that and mark this as unblocked unless anyone objects or thinks we should discuss it more broadly</p>



<a name="165256191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256191">(May 09 2019 at 14:15)</a>:</h4>
<p>OK there are <a href="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+label%3AI-nominated+label%3AT-compiler" target="_blank" title="https://github.com/rust-lang/rust/issues?utf8=%E2%9C%93&amp;q=is%3Aopen+label%3AI-nominated+label%3AT-compiler">a lot of I-nominated issues</a></p>



<a name="165256198"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256198" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256198">(May 09 2019 at 14:15)</a>:</h4>
<p><span class="user-mention" data-user-id="116466">@Zoxc</span> you want to start with the one you highlighted?</p>



<a name="165256256"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256256" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256256">(May 09 2019 at 14:16)</a>:</h4>
<p>I actually forget what that was</p>



<a name="165256286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256286">(May 09 2019 at 14:16)</a>:</h4>
<blockquote>
<p>Turn HIR indexing into a query <a href="https://github.com/rust-lang/rust/issues/59064" target="_blank" title="https://github.com/rust-lang/rust/issues/59064">#59064</a></p>
</blockquote>



<a name="165256305"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256305" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256305">(May 09 2019 at 14:17)</a>:</h4>
<p>My sense is that this might be a good candidate for the design meeting =)</p>



<a name="165256344"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256344" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256344">(May 09 2019 at 14:17)</a>:</h4>
<p>I might have nominated that?</p>



<a name="165256369"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256369" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256369">(May 09 2019 at 14:18)</a>:</h4>
<p>and yes, I think this is something that should be designed beforehand</p>



<a name="165256421"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256421" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256421">(May 09 2019 at 14:18)</a>:</h4>
<p>and agreed upon</p>



<a name="165256450"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256450" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256450">(May 09 2019 at 14:18)</a>:</h4>
<blockquote>
<p>How do we deal with a situation like this one where one member wants to work on something complicated with long-term effects but there is not enough bandwidth in the rest of the team to come up with (or at least think through and review) a proposed architecture/design?</p>
</blockquote>



<a name="165256453"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256453" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256453">(May 09 2019 at 14:18)</a>:</h4>
<p>that seems like context</p>



<a name="165256462"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256462" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256462">(May 09 2019 at 14:18)</a>:</h4>
<p>the PR, IIRC, is part of a series of PRs that do refactorings towards end-to-end queries</p>



<a name="165256467"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256467" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256467">(May 09 2019 at 14:18)</a>:</h4>
<p>Yeah</p>



<a name="165256520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256520">(May 09 2019 at 14:19)</a>:</h4>
<p>and there were a few things in this PR and the followups that would do non-trivial stuff around the query system</p>



<a name="165256524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256524">(May 09 2019 at 14:19)</a>:</h4>
<p>I don't think that PR should be discussed at the design meeting though, it's quite straightforward</p>



<a name="165256527"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256527" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256527">(May 09 2019 at 14:19)</a>:</h4>
<p>I am inclined to agree, I feel like this is exactly the sort of thing I had hope we would discuss in design meetings beforehand -- to try and get buy in on the general direction, and to help reviewers so they have an ide what the PR is trying to do</p>



<a name="165256600"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256600" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256600">(May 09 2019 at 14:20)</a>:</h4>
<blockquote>
<p>I don't think that PR should be discussed at the design meeting though, it's quite straightforward</p>
</blockquote>
<p>I dont' recall the specific PR, I was more referring to the overall plan</p>



<a name="165256626"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256626" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256626">(May 09 2019 at 14:20)</a>:</h4>
<p>But I guess there isn't overall agreement on it being straightforward based on <span class="user-mention" data-user-id="124287">@mw</span>'s comments :)</p>



<a name="165256698"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256698" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256698">(May 09 2019 at 14:21)</a>:</h4>
<p>Here are my concerns: <a href="https://github.com/rust-lang/rust/pull/59064#issuecomment-478565733" target="_blank" title="https://github.com/rust-lang/rust/pull/59064#issuecomment-478565733">https://github.com/rust-lang/rust/pull/59064#issuecomment-478565733</a></p>



<a name="165256721"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256721" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256721">(May 09 2019 at 14:21)</a>:</h4>
<p>and the subsequent PR looked like they did similar things</p>



<a name="165256852"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165256852" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165256852">(May 09 2019 at 14:22)</a>:</h4>
<p>So I think two things</p>
<ul>
<li>I can see that discussing the overall plan -- i.e., where do we think we're ending up, do we agree on the invariants etc might help here</li>
<li>But also it seems like another key question is finding the right person to act as "reviewer"</li>
</ul>



<a name="165257049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257049">(May 09 2019 at 14:25)</a>:</h4>
<p>OK, well, it seems like the comments have been made.</p>



<a name="165257227"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257227" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257227">(May 09 2019 at 14:27)</a>:</h4>
<p>I still feel like I would like to have a design meeting discussion laying out the overall plan that we are shooting for, and some of the intermediate steps. I don't know how much detail I want, perhaps not a ton, but it seems like something we can discuss. I also think we should try to figure out who will be the right person to do the reviewing, especially as <span class="user-mention" data-user-id="124287">@mw</span> will be doing on some further parental leave over the summer. I do think the PR seems like "the sort of step" that we are going to need though.</p>



<a name="165257330"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257330" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257330">(May 09 2019 at 14:28)</a>:</h4>
<p>(Put another way, I think this end-to-end work should probably be part of a working group, even if it's mostly a working group of 1?)</p>



<a name="165257345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257345">(May 09 2019 at 14:28)</a>:</h4>
<p>I've been reviewing some of the PRs, I don't think we need an @mw level reviewer for the PRs if the general direction is agreed upon</p>



<a name="165257368"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257368" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257368">(May 09 2019 at 14:28)</a>:</h4>
<p>Anyway, we gotta move on. I'll leave some comments and a pointer to what was said.</p>



<a name="165257370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257370">(May 09 2019 at 14:28)</a>:</h4>
<p>If we do something like this, there should be clear documentation on why it's done, what the pitfalls are and a way forward to remove the hack again, if possible</p>



<a name="165257381"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257381" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257381">(May 09 2019 at 14:28)</a>:</h4>
<blockquote>
<p>I've been reviewing some of the PRs, I don't think we need an @mw level reviewer for the PRs if the general direction is agreed upon</p>
</blockquote>
<p>(what does "mw level" mean?)</p>



<a name="165257419"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257419" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257419">(May 09 2019 at 14:29)</a>:</h4>
<p>well... deep knowledge of our incremental system</p>



<a name="165257420"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257420" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257420">(May 09 2019 at 14:29)</a>:</h4>
<p>I mostly mean that we should decide who will do it -- I think <span class="user-mention" data-user-id="124288">@oli</span> I'd be quite happy for you to do it :)</p>



<a name="165257424"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257424" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257424">(May 09 2019 at 14:29)</a>:</h4>
<p>Ah, ok</p>



<a name="165257647"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257647" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257647">(May 09 2019 at 14:31)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/59064#issuecomment-490929390" target="_blank" title="https://github.com/rust-lang/rust/pull/59064#issuecomment-490929390">Left my comment</a></p>



<a name="165257761"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257761" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257761">(May 09 2019 at 14:33)</a>:</h4>
<p>hmm, so we're at 32 minutes --</p>



<a name="165257787"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257787" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257787">(May 09 2019 at 14:33)</a>:</h4>
<p>I'm thinking we should try to spend more time on nominated or p-high issues</p>



<a name="165257792"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257792" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257792">(May 09 2019 at 14:33)</a>:</h4>
<p>until 45 after</p>



<a name="165257808"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257808" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257808">(May 09 2019 at 14:33)</a>:</h4>
<blockquote>
<p>Implement converting an AST to a token tree <a href="https://github.com/rust-lang/rust/issues/43081" target="_blank" title="https://github.com/rust-lang/rust/issues/43081">#43081</a></p>
</blockquote>



<a name="165257814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257814">(May 09 2019 at 14:33)</a>:</h4>
<p><span class="user-mention" data-user-id="119009">@eddyb</span> are you around?</p>



<a name="165257887"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257887" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257887">(May 09 2019 at 14:34)</a>:</h4>
<p>I think I will remove the nomination for this, but it seems like there is still ongoing design, and might make a great design meeting candidate too in time</p>



<a name="165257904"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257904" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257904">(May 09 2019 at 14:34)</a>:</h4>
<p>(pinged Eddy on Discord)</p>



<a name="165257986"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257986" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257986">(May 09 2019 at 14:35)</a>:</h4>
<blockquote>
<p>Pattern errors are too imprecise and should be removed in favor of MIR borrowck <a href="https://github.com/rust-lang/rust/issues/45600" target="_blank" title="https://github.com/rust-lang/rust/issues/45600">#45600</a></p>
</blockquote>



<a name="165257997"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165257997" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165257997">(May 09 2019 at 14:35)</a>:</h4>
<p>this was nominated by <span class="user-mention" data-user-id="119031">@Esteban Küber</span> but I suspect we can remove that</p>



<a name="165258016"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258016" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258016">(May 09 2019 at 14:35)</a>:</h4>
<p>in particular, there's been some discussion in the meantime</p>



<a name="165258068"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258068" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258068">(May 09 2019 at 14:36)</a>:</h4>
<p>(actually maybe we'll touch on that today as part of <span class="user-group-mention" data-user-group-id="491">@WG-nll</span> check-in)</p>



<a name="165258095"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258095" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258095">(May 09 2019 at 14:36)</a>:</h4>
<p>(I thought you said WG-nll was over?)</p>



<a name="165258109"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258109" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258109">(May 09 2019 at 14:36)</a>:</h4>
<p>well, it's still on the check-in calendar :P</p>



<a name="165258116"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258116" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258116">(May 09 2019 at 14:36)</a>:</h4>
<p>/me is ruled by the calendar</p>



<a name="165258131"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258131" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258131">(May 09 2019 at 14:37)</a>:</h4>
<p>(but I agree it's basically over at this point, and was going to raise that point)</p>



<a name="165258140"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258140" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258140">(May 09 2019 at 14:37)</a>:</h4>
<blockquote>
<p>Panics in destructors can cause the return value to be leaked <a href="https://github.com/rust-lang/rust/issues/47949" target="_blank" title="https://github.com/rust-lang/rust/issues/47949">#47949</a></p>
</blockquote>



<a name="165258156"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258156" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258156">(May 09 2019 at 14:37)</a>:</h4>
<p>I guess this is more nomated for lang; it's a longstanding "weird case"</p>



<a name="165258168"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258168" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258168">(May 09 2019 at 14:37)</a>:</h4>
<p>(since 1.0)</p>



<a name="165258169"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258169" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Esteban Küber <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258169">(May 09 2019 at 14:37)</a>:</h4>
<p>I think the biggest discussion is wether we want to remove that pattern checker in lieu of relying on the borrow checker and if we do, does that require an rfc because we'd start accepting more code.</p>



<a name="165258201"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258201" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258201">(May 09 2019 at 14:37)</a>:</h4>
<p><span class="user-mention" data-user-id="119031">@Esteban Küber</span> that's a T-Lang discussion however</p>



<a name="165258202"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258202" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258202">(May 09 2019 at 14:37)</a>:</h4>
<blockquote>
<p>I think the biggest discussion is wether we want to remove that pattern checker in lieu of relying on the borrow checker and if we do, does that require an rfc because we'd start accepting more code.</p>
</blockquote>
<p>ah, ok. I feel like we always "intended to" as part of NLL but it wasn't explicitly discussed as such</p>



<a name="165258210"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258210" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258210">(May 09 2019 at 14:37)</a>:</h4>
<p>in fact, I think we <em>had</em> an RFC about it maybe? I can't remember</p>



<a name="165258271"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258271" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258271">(May 09 2019 at 14:38)</a>:</h4>
<p>in any case, we <em>did</em> cover this a bit in T-lang ..</p>



<a name="165258295"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258295" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258295">(May 09 2019 at 14:38)</a>:</h4>
<p>yeah; bind by move &amp; stuff</p>



<a name="165258309"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258309" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258309">(May 09 2019 at 14:38)</a>:</h4>
<p>Matthew helpfully made a preliminary report</p>



<a name="165258317"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258317" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258317">(May 09 2019 at 14:38)</a>:</h4>
<blockquote>
<p>Exponential compile-time and type_length_limit blowup when nesting closure wrappers <a href="https://github.com/rust-lang/rust/issues/54540" target="_blank" title="https://github.com/rust-lang/rust/issues/54540">#54540</a></p>
</blockquote>



<a name="165258319"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258319" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258319">(May 09 2019 at 14:38)</a>:</h4>
<p>I nominated this</p>



<a name="165258327"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258327" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258327">(May 09 2019 at 14:38)</a>:</h4>
<p>mostly beacuse <span class="user-mention" data-user-id="119009">@eddyb</span> and I were talking about it last time</p>



<a name="165258336"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258336" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258336">(May 09 2019 at 14:39)</a>:</h4>
<p>it's more  of a "volunteer task" than anything I guess</p>



<a name="165258357"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258357" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258357">(May 09 2019 at 14:39)</a>:</h4>
<p>I'm going to remove nomination</p>



<a name="165258370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258370">(May 09 2019 at 14:39)</a>:</h4>
<blockquote>
<p>Update dependency versions in the various <code>Cargo.toml</code>s to the version that we actually use <a href="https://github.com/rust-lang/rust/issues/57443" target="_blank" title="https://github.com/rust-lang/rust/issues/57443">#57443</a></p>
</blockquote>



<a name="165258375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258375">(May 09 2019 at 14:39)</a>:</h4>
<p><span class="user-mention" data-user-id="124288">@oli</span> nominated this</p>



<a name="165258379"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258379" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258379">(May 09 2019 at 14:39)</a>:</h4>
<blockquote>
<p>Nominating for discussion at the team meeting. Let's create a repo for this. It's a general purpose tool that we want to use in rustbuild. As per this year's strategy of moving things out of tree, I want to start this out of tree. I can take care of everything once we have a repo where I have merge or r+ powers.</p>
</blockquote>



<a name="165258389"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258389" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258389">(May 09 2019 at 14:39)</a>:</h4>
<p>oh yea, so the thing is less the impl, but whether we are ok to create a new repo and <em>start</em> out of tree</p>



<a name="165258440"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258440" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258440">(May 09 2019 at 14:40)</a>:</h4>
<p>works for me</p>



<a name="165258455"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258455" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258455">(May 09 2019 at 14:40)</a>:</h4>
<p>we did have a sketch of a process on this</p>



<a name="165258461"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258461" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258461">(May 09 2019 at 14:40)</a>:</h4>
<p>but it was pretty informal, maybe a PR or something..?</p>



<a name="165258483"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258483" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258483">(May 09 2019 at 14:40)</a>:</h4>
<p>An idea: have a bot tell us when a dependency is outdated by making an issue</p>



<a name="165258490"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258490" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258490">(May 09 2019 at 14:40)</a>:</h4>
<p>hmm.. I'll search around and if I don't find anything... I'll add a process thing to the compiler-team repo?</p>



<a name="165258529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258529">(May 09 2019 at 14:41)</a>:</h4>
<p>The procedure is <a href="https://github.com/rust-lang/compiler-team/blob/master/procedures/crates.md" target="_blank" title="https://github.com/rust-lang/compiler-team/blob/master/procedures/crates.md">described here</a></p>



<a name="165258539"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258539" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258539">(May 09 2019 at 14:41)</a>:</h4>
<blockquote>
<p>Create a PR modifying this document to include the crate in the list below. Use @rfcbot merge to gain agreement from compiler team members.</p>
</blockquote>



<a name="165258557"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258557" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258557">(May 09 2019 at 14:41)</a>:</h4>
<p>it's a bit .. hidden in that document though</p>



<a name="165258559"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258559" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258559">(May 09 2019 at 14:41)</a>:</h4>
<p>cool... I should have looked around</p>



<a name="165258560"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258560" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258560">(May 09 2019 at 14:41)</a>:</h4>
<p>took me a bit to find it</p>



<a name="165258571"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258571" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258571">(May 09 2019 at 14:41)</a>:</h4>
<p>maybe should be made more prominent :)</p>



<a name="165258580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258580">(May 09 2019 at 14:42)</a>:</h4>
<p>ok, that is resolved then. I'll start the process and try to make the doc more visible</p>



<a name="165258627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258627">(May 09 2019 at 14:42)</a>:</h4>
<p>+1</p>



<a name="165258728"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258728" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258728">(May 09 2019 at 14:43)</a>:</h4>
<blockquote>
<p>mir-opt tests extremely slow. <a href="https://github.com/rust-lang/rust/issues/58485" target="_blank" title="https://github.com/rust-lang/rust/issues/58485">#58485</a></p>
</blockquote>



<a name="165258750"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258750" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258750">(May 09 2019 at 14:43)</a>:</h4>
<p>I don't know why this is nominated</p>



<a name="165258760"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258760" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258760">(May 09 2019 at 14:43)</a>:</h4>
<p>seems like it's p-medium, nice to have, etc?</p>



<a name="165258831"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258831" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258831">(May 09 2019 at 14:44)</a>:</h4>
<p>Ah, I guess, "Nominating for discussion (specifically, investigating this) at the next @rust-lang/compiler team meeting.", but I think we're all set</p>



<a name="165258877"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258877" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258877">(May 09 2019 at 14:44)</a>:</h4>
<p>Oh, I guess it was whether to port to use ui tests ? (I think that seems fine...)</p>



<a name="165258896"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258896" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258896">(May 09 2019 at 14:45)</a>:</h4>
<p>(If more discussion is needed, we can use the design meeting for that)</p>



<a name="165258914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258914">(May 09 2019 at 14:45)</a>:</h4>
<p>OK, that's all the time we've got</p>



<a name="165258932"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165258932" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165258932">(May 09 2019 at 14:45)</a>:</h4>
<p>Let's do some quick check-ins. First, </p>
<blockquote>
<p>WG-Diagnostics</p>
</blockquote>
<p><span class="user-mention" data-user-id="124288">@oli</span> was going to tell us about <span class="user-group-mention" data-user-group-id="1187">@WG-diagnostics</span></p>



<a name="165259007"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259007" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259007">(May 09 2019 at 14:46)</a>:</h4>
<p>so I just checked, and we have not done anything towards our goal of ripping diagnostics out of the compiler that I know of. Maybe <span class="user-mention" data-user-id="119031">@Esteban Küber</span> knows more.</p>



<a name="165259011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259011">(May 09 2019 at 14:46)</a>:</h4>
<p>We haven't had a first meeting yet, so I'll organize that</p>



<a name="165259049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259049">(May 09 2019 at 14:46)</a>:</h4>
<p>OK =)</p>



<a name="165259053"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259053" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259053">(May 09 2019 at 14:47)</a>:</h4>
<p>Sounds good!</p>



<a name="165259126"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259126" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259126">(May 09 2019 at 14:47)</a>:</h4>
<p>Next was <span class="user-group-mention" data-user-group-id="491">@WG-nll</span> -- there remain a few items of follow-up:</p>
<ul>
<li>Enabling migration mode for Rust 2015</li>
<li>The bind-by-move-in-match stuff</li>
</ul>



<a name="165259184"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259184" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259184">(May 09 2019 at 14:48)</a>:</h4>
<p>(There is no more regular meeting etc though)</p>



<a name="165259195"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259195" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259195">(May 09 2019 at 14:48)</a>:</h4>
<p>To be quite honest I've been too busy to keep up with those items, but I don't think <span class="user-mention" data-user-id="116118">@Matthew Jasper</span> is here right now to fill us in</p>



<a name="165259205"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259205" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259205">(May 09 2019 at 14:48)</a>:</h4>
<p>Er, well, <a href="https://github.com/rust-lang/rust/pull/59114" target="_blank" title="https://github.com/rust-lang/rust/pull/59114">https://github.com/rust-lang/rust/pull/59114</a> mergd -- so I guess we have migration mode on 2015</p>



<a name="165259222"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259222" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259222">(May 09 2019 at 14:48)</a>:</h4>
<p><span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="165259224"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259224" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259224">(May 09 2019 at 14:49)</a>:</h4>
<p>we do; NLL is on 2015 in 1.36</p>



<a name="165259239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259239">(May 09 2019 at 14:49)</a>:</h4>
<p>So then the question now is to establish the precise criteria for the next step, killing the old AST borrow checker.</p>



<a name="165259272"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259272" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259272">(May 09 2019 at 14:49)</a>:</h4>
<p>if everything is using NLL now, is there any reason to wait?</p>



<a name="165259281"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259281" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259281">(May 09 2019 at 14:49)</a>:</h4>
<p>We should probably create a tracking issue for this (or maybe a GH project)</p>



<a name="165259300"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259300" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259300">(May 09 2019 at 14:49)</a>:</h4>
<blockquote>
<p>if everything is using NLL now, is there any reason to wait?</p>
</blockquote>
<p>yes, because migation mode gives warnings for old patterns that used to be (incorrectly) accepted</p>



<a name="165259355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> varkor <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259355">(May 09 2019 at 14:50)</a>:</h4>
<p>ah, of course</p>



<a name="165259359"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259359" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259359">(May 09 2019 at 14:50)</a>:</h4>
<p>we'll have to give people time to fix those, do crater runs, and all that</p>



<a name="165259370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259370">(May 09 2019 at 14:50)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> next step might be to do crater then?</p>



<a name="165259371"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259371" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259371">(May 09 2019 at 14:50)</a>:</h4>
<p>there may also be some outstanding bugs we wanted to fix</p>



<a name="165259397"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259397" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259397">(May 09 2019 at 14:50)</a>:</h4>
<p>seems like we need to "take stock" of the full set of items</p>



<a name="165259403"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259403" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259403">(May 09 2019 at 14:50)</a>:</h4>
<p>(this is where I remind y'all of the virtues of minimum lint levels ^,-)</p>



<a name="165259467"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259467" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259467">(May 09 2019 at 14:51)</a>:</h4>
<p>OK, well, that's all there is to say on that, I think.</p>



<a name="165259653"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259653" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259653">(May 09 2019 at 14:52)</a>:</h4>
<p>We've got a few minutes left...</p>



<a name="165259675"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259675" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259675">(May 09 2019 at 14:53)</a>:</h4>
<p>I'm going to try to get through a few I-nominated issues dang it</p>



<a name="165259738"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259738" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259738">(May 09 2019 at 14:53)</a>:</h4>
<blockquote>
<p>Decouple nightly RLS from Clippy <a href="https://github.com/rust-lang/rust/issues/59761" target="_blank" title="https://github.com/rust-lang/rust/issues/59761">#59761</a></p>
</blockquote>



<a name="165259809"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259809" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259809">(May 09 2019 at 14:54)</a>:</h4>
<p>I'd like to quickly discuss <a href="https://github.com/rust-lang/rust/pull/59752" target="_blank" title="https://github.com/rust-lang/rust/pull/59752">https://github.com/rust-lang/rust/pull/59752</a> if possible</p>



<a name="165259810"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259810" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259810">(May 09 2019 at 14:54)</a>:</h4>
<p>This was nominated by <span class="user-mention" data-user-id="125254">@kennytm</span> -- but I'm not sure what there is to discuss. Maybe it was nominated for dev-tools though</p>



<a name="165259827"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259827" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259827">(May 09 2019 at 14:54)</a>:</h4>
<blockquote>
<p>Limit dylib symbols <a href="https://github.com/rust-lang/rust/issues/59752" target="_blank" title="https://github.com/rust-lang/rust/issues/59752">#59752</a></p>
</blockquote>



<a name="165259828"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259828" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259828">(May 09 2019 at 14:54)</a>:</h4>
<p>Go for it :)</p>



<a name="165259854"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259854" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259854">(May 09 2019 at 14:54)</a>:</h4>
<p>here's a summary: <a href="https://github.com/rust-lang/rust/pull/59752#issuecomment-490020239" target="_blank" title="https://github.com/rust-lang/rust/pull/59752#issuecomment-490020239">https://github.com/rust-lang/rust/pull/59752#issuecomment-490020239</a></p>



<a name="165259884"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259884" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259884">(May 09 2019 at 14:55)</a>:</h4>
<blockquote>
<p>This PR "fixes" how we export symbols from Rust dylibs by giving the linker an explicit list of symbols to export. I'm writing "fixes" in quotes here because:</p>
<div class="codehilite"><pre><span></span>we actually don&#39;t define what symbols get exported from Rust dylibs exactly
the current behavior is inconsistent between different platforms
there&#39;s at least one case that relies on the more lenient behavior on some platforms.
</pre></div>


<p>So the PR makes things more consistent but breaks something that relies on underspecified behavior. I'm wondering what to do here. Crater doesn't show breakage for the change, the problematic case seems to have a proposed fix upstream and Rust dylibs aren't used that much in the wild anyway. On the other hand this isn't an urgent problem and the PR might introduce breakage.</p>
<p>Ideally we'd fix the situation around Rust dylibs (by either deprecating them or specifying them more completely).</p>
<p>Meanwhile, do we want to merge this?</p>
</blockquote>



<a name="165259891"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259891" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259891">(May 09 2019 at 14:55)</a>:</h4>
<p>the PR makes Rust dylibs more consistent across platforms</p>



<a name="165259911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259911">(May 09 2019 at 14:55)</a>:</h4>
<p>it breaks a bit of stuff</p>



<a name="165259921"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259921" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259921">(May 09 2019 at 14:55)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116015">@Alex Crichton</span></p>



<a name="165259930"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259930" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259930">(May 09 2019 at 14:55)</a>:</h4>
<p>but that relies on things that we don't really guarantee</p>



<a name="165259948"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259948" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259948">(May 09 2019 at 14:56)</a>:</h4>
<p>which is easy because Rust dylibs are rather shaky to begin with</p>



<a name="165259952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259952">(May 09 2019 at 14:56)</a>:</h4>
<p><span class="user-mention" data-user-id="116015">@Alex Crichton</span> wrote:</p>
<blockquote>
<p>To throw in my personal opinion, I'm all for locking down the dylib crate type to basically "work for rustc as priority number 1 and we'll figure other things out later". Other use cases of dynamic libraries in Rust should all be using cdylib which is much more appropriate and has better definitions about symbols and whatnot. For dylib we've largely (AFAIK) just kept it working for the compiler and haven't really done much else to it.</p>
</blockquote>



<a name="165259996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165259996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> kennytm <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165259996">(May 09 2019 at 14:56)</a>:</h4>
<blockquote>
<p>This was nominated by <span class="user-mention silent" data-user-id="125254">kennytm</span> -- but I'm not sure what there is to discuss. Maybe it was nominated for dev-tools though</p>
</blockquote>
<p>(59761 was nominated for T-infra when that issue still had that label)</p>



<a name="165260005"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260005" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260005">(May 09 2019 at 14:56)</a>:</h4>
<p>I'd like to merge</p>



<a name="165260027"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260027" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260027">(May 09 2019 at 14:56)</a>:</h4>
<p>Have we reached out to the case that we know to be affected?</p>



<a name="165260029"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260029" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260029">(May 09 2019 at 14:56)</a>:</h4>
<p>but there might be breakage so I wanted to at least inform the compiler team</p>



<a name="165260038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260038">(May 09 2019 at 14:56)</a>:</h4>
<p>yes, we have</p>



<a name="165260060"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260060" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260060">(May 09 2019 at 14:56)</a>:</h4>
<p>there's a PR open to fix the issue, I think</p>



<a name="165260062"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260062" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260062">(May 09 2019 at 14:56)</a>:</h4>
<p>OK, I am ok to merge. I wonder where we would document this sort of thing.</p>



<a name="165260087"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260087" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260087">(May 09 2019 at 14:57)</a>:</h4>
<p>document what exactly?</p>



<a name="165260260"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260260" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260260">(May 09 2019 at 14:58)</a>:</h4>
<p>what symbols etc are expected to be exported</p>



<a name="165260286"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260286" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260286">(May 09 2019 at 14:58)</a>:</h4>
<p>I feel like this is an area where I would like input -- I see Josh Tripplet sort of weighed in a bit on thread</p>



<a name="165260341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Vadim Petrochenkov <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260341">(May 09 2019 at 14:59)</a>:</h4>
<p>I'd rather document something in the direction of dylib being unstable, deprecated and for internal use only.</p>



<a name="165260366"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260366" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260366">(May 09 2019 at 14:59)</a>:</h4>
<p>that seems fine to document for now</p>



<a name="165260443"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260443" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260443">(May 09 2019 at 15:00)</a>:</h4>
<p>eventually I think we may want to support it more properly though</p>



<a name="165260471"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260471" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260471">(May 09 2019 at 15:00)</a>:</h4>
<p>anyway, i'm fine with this, but I'd like to hear back from josh tripplet on his opinion</p>



<a name="165260479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260479">(May 09 2019 at 15:00)</a>:</h4>
<p>(reading some backscroll now)</p>



<a name="165260489"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260489" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260489">(May 09 2019 at 15:01)</a>:</h4>
<p>I'm not entirely clear btw if this is "t-compiler" or "t-lang" or what =) it's... t-something</p>



<a name="165260544"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260544" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260544">(May 09 2019 at 15:01)</a>:</h4>
<p>the underlying issue is t-lang, I'd say</p>



<a name="165260545"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260545" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> centril <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260545">(May 09 2019 at 15:01)</a>:</h4>
<p><span class="user-mention" data-user-id="116009">@nikomatsakis</span> when in doubt, say "both" :P</p>



<a name="165260555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260555">(May 09 2019 at 15:01)</a>:</h4>
<p><span class="user-mention" data-user-id="124287">@mw</span> so the main breakage is that C symbols not declared in rust don't show up, right?</p>



<a name="165260566"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260566" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260566">(May 09 2019 at 15:01)</a>:</h4>
<p>or are there other forms of breakage that we know of?</p>



<a name="165260631"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260631" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260631">(May 09 2019 at 15:02)</a>:</h4>
<p>the crater run came back clean</p>



<a name="165260645"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260645" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260645">(May 09 2019 at 15:02)</a>:</h4>
<p>I don't think C symbol will show up at all</p>



<a name="165260651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260651">(May 09 2019 at 15:02)</a>:</h4>
<p>but this is rather platform dependent, so I don't know</p>



<a name="165260701"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260701" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260701">(May 09 2019 at 15:03)</a>:</h4>
<p>C symbols need to show up at least somewhat for the compiler to work over time</p>



<a name="165260725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260725">(May 09 2019 at 15:03)</a>:</h4>
<p>we only know that it broke that one crate because it's used by rustc during bootstrap, I think</p>



<a name="165260727"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260727" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260727">(May 09 2019 at 15:03)</a>:</h4>
<p>e.g. if you have an <code>#[inline]</code> function in one dylib calling a C symbol linked into that dylib</p>



<a name="165260753"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260753" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260753">(May 09 2019 at 15:03)</a>:</h4>
<p>that was just the crate trying to use LLVM symbols implicitly through the dylib we have, right?</p>



<a name="165260770"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260770" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260770">(May 09 2019 at 15:03)</a>:</h4>
<p>yes</p>



<a name="165260889"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260889" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260889">(May 09 2019 at 15:04)</a>:</h4>
<p>ok, I just wanted to confirm</p>



<a name="165260894"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260894" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Alex Crichton <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260894">(May 09 2019 at 15:04)</a>:</h4>
<p>I'm still in favor...</p>



<a name="165260899"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260899" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260899">(May 09 2019 at 15:04)</a>:</h4>
<p>let's maybe wait until the beginning of the next cycle with merging</p>



<a name="165260944"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/weekly%20meeting%202019-05-09%20%2354818/near/165260944" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mw <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/weekly.20meeting.202019-05-09.20.2354818.html#165260944">(May 09 2019 at 15:05)</a>:</h4>
<p>then we should be on the safe side</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>